Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(js): memory allocation in filtered spans #104

Merged
merged 4 commits into from
Aug 21, 2023
Merged

fix(js): memory allocation in filtered spans #104

merged 4 commits into from
Aug 21, 2023

Conversation

wikiwong
Copy link
Contributor

  • Hoist (and sum) memory allocations to parent span when current span is being filtered
  • fix bug in which allocations created their own spans for otel based adapters

@wikiwong wikiwong merged commit 3ce3664 into main Aug 21, 2023
@wikiwong wikiwong deleted the fix-js-mem-alloc branch August 21, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilslice nilslice nilslice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wikiwong @nilslice